search

AthanorLabs / atomic-swap

💫 ETH-XMR atomic swap implementation
GNU Lesser General Public License v3.0
341 stars 44 forks source link

swapcli command to subcribe to ongoing swap #453

Closed dimalinux closed 1 year ago

dimalinux commented 1 year ago

We have a subscribeSwapStatus RPC endpoint, but never extended swapcli to be able to attach/subscribe to an ongoing swap.

dimalinux commented 1 year ago

I'm having second thoughts as to whether this would be a good feature without a backend architecture change. Right now we are using a channel. If 2 clients subscribe to the same swap, only one of the two clients will get each of the successive state changes. It could become a support headache if end users run swapcli make in one window and then swapcli subscribe in a different windows. I'm thinking we don't want this feature until/unless we allow multiple subscribers to the same offer ID, where every subscriber gets the updates.

dimalinux commented 1 year ago

I'm going to close this issue for now, based on the reason mentioned in the previous comment.