AthanorLabs / atomic-swap

💫 ETH-XMR atomic swap implementation
GNU Lesser General Public License v3.0
341 stars 44 forks source link

added new waitForNewSwapReceipt method for xmrmaker #455

Closed dimalinux closed 1 year ago

dimalinux commented 1 year ago

Adds a new waitForNewSwapReceipt method for when the maker receives the NewSwap TX has from the taker. The maker might not see the TX as having been minded into a block immediately even if the taker already saw it.

Consolidates test code for deploying the swap creator contract.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 86.44% and project coverage change: +0.04 :tada:

Comparison is base (e3c24b5) 58.50% compared to head (1cb2a30) 58.54%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #455 +/- ## ========================================== + Coverage 58.50% 58.54% +0.04% ========================================== Files 123 124 +1 Lines 11581 11620 +39 ========================================== + Hits 6775 6803 +28 - Misses 4087 4094 +7 - Partials 719 723 +4 ``` | [Impacted Files](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [tests/ganache.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-dGVzdHMvZ2FuYWNoZS5nbw==) | `80.00% <71.42%> (-0.73%)` | :arrow_down: | | [protocol/xmrmaker/message\_handler.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHJvdG9jb2wveG1ybWFrZXIvbWVzc2FnZV9oYW5kbGVyLmdv) | `62.34% <75.00%> (+1.91%)` | :arrow_up: | | [daemon/test\_support.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZGFlbW9uL3Rlc3Rfc3VwcG9ydC5nbw==) | `99.15% <100.00%> (-0.09%)` | :arrow_down: | | [ethereum/deploy\_util.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZXRoZXJldW0vZGVwbG95X3V0aWwuZ28=) | `42.30% <100.00%> (ø)` | | | [ethereum/test\_support.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZXRoZXJldW0vdGVzdF9zdXBwb3J0Lmdv) | `100.00% <100.00%> (ø)` | | | [protocol/xmrmaker/swap\_state.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHJvdG9jb2wveG1ybWFrZXIvc3dhcF9zdGF0ZS5nbw==) | `66.35% <100.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/455/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.