codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 100.00% and project coverage change: +0.20 :tada:
Comparison is base (
0abc9e6) 58.00% compared to head (06437b4) 58.20%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #469 +/- ## ========================================== + Coverage 58.00% 58.20% +0.20% ========================================== Files 127 127 Lines 12185 12223 +38 ========================================== + Hits 7068 7115 +47 + Misses 4376 4367 -9 Partials 741 741 ``` | [Impacted Files](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [bootnode/bootnode.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ym9vdG5vZGUvYm9vdG5vZGUuZ28=) | `66.00% <100.00%> (ø)` | | | [cmd/bootnode/main.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y21kL2Jvb3Rub2RlL21haW4uZ28=) | `66.66% <100.00%> (ø)` | | | [daemon/test\_support.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZGFlbW9uL3Rlc3Rfc3VwcG9ydC5nbw==) | `99.36% <100.00%> (+0.20%)` | :arrow_up: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/469/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
The daemon tests were previously using the first
swapdinstance created byLaunchDaemonsas the bootnode for all subsequent daemons. This made writing more complicated tests fragile. If you passedLaunchDaemons(... aliceConf, bobConf), you couldn't stop and restart Bob's swapd instance unless Alice's was still online as one example. I'm working on tests that need this feature and wanted to get the infrastructure changes in as a separate PR.