Closed stubbrn closed 1 year ago
Patch coverage: 45.11
% and project coverage change: +0.09
:tada:
Comparison is base (
c5bd052
) 58.78% compared to head (e8b3b86
) 58.88%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Received: 0.1 ETH (minus 0.01 ETH relayer fee)
Question: Do we want to write it like this, or do we want to write the actual amount received, then in parenthesis write the amount paid in relayer fees? I don't think it is critical, but I'd lean towards the exact amount received being a more helpful value. Do we want the fees in parentheses or as a separate line item?
Additional questions: For the taker, do we want to summarize what they paid in ETH fees across the newSwap/setReady transactions? Do we want to track the relatively low XMR fees? The XMR fees may be low enough that we don't care, not sure.
Whatever the answers, I'm not suggesting that they all make it into this PR. But I think we should answer all the questions to know what smaller steps take us in the right direction.
Question: Do we want to write it like this, or do we want to write the actual amount received, then in parenthesis write the amount paid in relayer fees? I don't think it is critical, but I'd lean towards the exact amount received being a more helpful value. Do we want the fees in parentheses or as a separate line item?
I agree, the exact amount received seems more intuitive. @noot ?
@stubbrn yeah, I think putting the exact amount received makes sense, but it would be good to mention received amount = (before fee swap amount - relayer fee)
somewhere so people aren't asking where the extra 0.01 ETH went lol.
Looks like this now:
Received: 0.09 ETH (0.1 ETH - 0.01 ETH relayer fee)
closes #419
swapcli past
looks like this: