AthanorLabs / atomic-swap

💫 ETH-XMR atomic swap implementation
GNU Lesser General Public License v3.0
341 stars 44 forks source link

query-all no longer reports peers with no current offers #476

Closed dimalinux closed 1 year ago

dimalinux commented 1 year ago

The query-all command to swapcli was reporting nodes that had presumably offered XMR at some point, but didn't have any current offers. This PR just prunes nodes with no offers from the returned results.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 :warning:

Comparison is base (b5a83d5) 58.79% compared to head (bc8d2cd) 58.78%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #476 +/- ## ========================================== - Coverage 58.79% 58.78% -0.01% ========================================== Files 128 128 Lines 12183 12185 +2 ========================================== Hits 7163 7163 + Misses 4279 4278 -1 - Partials 741 744 +3 ``` | [Impacted Files](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/476?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [rpc/net.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/476?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cnBjL25ldC5nbw==) | `56.61% <100.00%> (+0.64%)` | :arrow_up: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/476/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.