AthanorLabs / atomic-swap

💫 ETH-XMR atomic swap implementation
GNU Lesser General Public License v3.0
344 stars 44 forks source link

fixed taker ERC20 over/under error messages #483

Closed dimalinux closed 1 year ago

dimalinux commented 1 year ago

The taker over/under error messages were printing "ETH" even when the provided asset was a token.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 83.33% and project coverage change: +1.09 :tada:

Comparison is base (0f1865c) 58.68% compared to head (4f71f63) 59.77%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #483 +/- ## ========================================== + Coverage 58.68% 59.77% +1.09% ========================================== Files 128 128 Lines 12608 12612 +4 ========================================== + Hits 7399 7539 +140 + Misses 4452 4300 -152 - Partials 757 773 +16 ``` | [Impacted Files](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/483?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [rpcclient/ws\_methods.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/483?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cnBjY2xpZW50L3dzX21ldGhvZHMuZ28=) | `54.16% <0.00%> (ø)` | | | [protocol/xmrtaker/errors.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/483?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHJvdG9jb2wveG1ydGFrZXIvZXJyb3JzLmdv) | `90.32% <100.00%> (+1.43%)` | :arrow_up: | | [protocol/xmrtaker/net.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/483?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHJvdG9jb2wveG1ydGFrZXIvbmV0Lmdv) | `81.48% <100.00%> (ø)` | | ... and [15 files with indirect coverage changes](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/483/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.