AthanorLabs / atomic-swap

💫 ETH-XMR atomic swap implementation
GNU Lesser General Public License v3.0
344 stars 44 forks source link

updates for cross-chain bootnodes #486

Closed dimalinux closed 1 year ago

dimalinux commented 1 year ago

This PR depends on https://github.com/AthanorLabs/go-p2p-net/pull/9, which should get merged with a new release tag first.

We don't want to maintain separate sets of bootnodes for every supported environment. The go-p2p-net library, which was already adding a protocol ID prefix to stream names, was adjusted to add the same prefixes to advertised-in-the-DHT namespaces. Instead of advertising "XMR" in the namespace, swapd instance will now advertise /atomic-swap/${chain_name}/${protocol_version}/XMR instead.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 94.52% and project coverage change: -0.09 :warning:

Comparison is base (8941163) 61.00% compared to head (4d7d99d) 60.91%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #486 +/- ## ========================================== - Coverage 61.00% 60.91% -0.09% ========================================== Files 129 129 Lines 12843 12834 -9 ========================================== - Hits 7835 7818 -17 - Misses 4189 4197 +8 Partials 819 819 ``` | [Impacted Files](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [cliutil/log.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2xpdXRpbC9sb2cuZ28=) | `94.73% <ø> (ø)` | | | [cliutil/signal\_handler.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2xpdXRpbC9zaWduYWxfaGFuZGxlci5nbw==) | `25.00% <ø> (-56.25%)` | :arrow_down: | | [cliutil/utils.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2xpdXRpbC91dGlscy5nbw==) | `58.59% <ø> (ø)` | | | [coins/common.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y29pbnMvY29tbW9uLmdv) | `100.00% <ø> (ø)` | | | [daemon/test\_support.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZGFlbW9uL3Rlc3Rfc3VwcG9ydC5nbw==) | `99.13% <ø> (-0.01%)` | :arrow_down: | | [db/database.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZGIvZGF0YWJhc2UuZ28=) | `64.58% <ø> (ø)` | | | [ethereum/block/wait\_for\_receipt.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZXRoZXJldW0vYmxvY2svd2FpdF9mb3JfcmVjZWlwdC5nbw==) | `80.00% <ø> (ø)` | | | [ethereum/deploy\_util.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZXRoZXJldW0vZGVwbG95X3V0aWwuZ28=) | `42.30% <ø> (ø)` | | | [ethereum/extethclient/eth\_wallet\_client.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZXRoZXJldW0vZXh0ZXRoY2xpZW50L2V0aF93YWxsZXRfY2xpZW50Lmdv) | `67.06% <ø> (ø)` | | | [ethereum/watcher/watcher.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZXRoZXJldW0vd2F0Y2hlci93YXRjaGVyLmdv) | `75.00% <ø> (-6.25%)` | :arrow_down: | | ... and [21 more](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/486?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/486/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.