search

AthanorLabs / atomic-swap

💫 ETH-XMR atomic swap implementation
GNU Lesser General Public License v3.0
344 stars 44 forks source link

update mainnet bootnodes #487

Closed noot closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.17 :warning:

Comparison is base (8941163) 61.00% compared to head (3ee3254) 60.84%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #487 +/- ## ========================================== - Coverage 61.00% 60.84% -0.17% ========================================== Files 129 129 Lines 12843 12843 ========================================== - Hits 7835 7814 -21 - Misses 4189 4205 +16 - Partials 819 824 +5 ``` | [Impacted Files](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [common/config.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y29tbW9uL2NvbmZpZy5nbw==) | `81.66% <100.00%> (ø)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/487/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dimalinux commented 1 year ago

Can you just make this change directly in the other open PR so we don't get a merge conflict?

dimalinux commented 1 year ago

Can you just make this change directly in the other open PR so we don't get a merge conflict?

Actually, there is no need. I had already corrected both of those in the dimalinux/cross-chain-bootnodes PR that is waiting for review. The cross-chain-bootnodes PR adds a TestPublicBootnodes test that is skipped in CI, but is really useful for determining which bootnodes are bad and usually why. I'll just close this PR.