search

AthanorLabs / atomic-swap

💫 ETH-XMR atomic swap implementation
GNU Lesser General Public License v3.0
341 stars 44 forks source link

Warning if swapcli and swapd are on different versions #490

Open dimalinux opened 1 year ago

dimalinux commented 1 year ago

Do we want some kind of warning when swapcli and swapd not the same version?

$ ./bin/swapcli version
swapcli: v0.4.0-go1.20.5
swapd: dev-7619b9a-dirty-go1.20.5
p2p version: /atomic-swap/mainnet/2
env: mainnet
swap creator address: 0x377ed3a60007048DF00135637521170628De89E5

I think that's what other programs do. If someone has a suggestion on what the warning should look like, please add a comment here.

I'd probably just add a line at the end like this:

$ ./bin/swapcli version
swapcli: v0.4.0-go1.20.5
swapd: dev-7619b9a-dirty-go1.20.5
p2p version: /atomic-swap/mainnet/2
env: mainnet
swap creator address: 0x377ed3a60007048DF00135637521170628De89E5

WARNING: client and server versions are different