AthanorLabs / atomic-swap

💫 ETH-XMR atomic swap implementation
GNU Lesser General Public License v3.0
341 stars 44 forks source link

exchange rate labeling updates #493

Closed dimalinux closed 1 year ago

dimalinux commented 1 year ago

Someone put up a mainnet swap with an exchange rate of 0.1. I realized that our help could be clearer and while our code commentary in various places was correct on the numerator/denominator labeling, the swapcli output had it backwards.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.07 :tada:

Comparison is base (7619b9a) 60.79% compared to head (420000a) 60.87%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #493 +/- ## ========================================== + Coverage 60.79% 60.87% +0.07% ========================================== Files 129 129 Lines 12834 12837 +3 ========================================== + Hits 7802 7814 +12 + Misses 4208 4201 -7 + Partials 824 822 -2 ``` | [Impacted Files](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [common/config.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y29tbW9uL2NvbmZpZy5nbw==) | `81.51% <ø> (ø)` | | | [cmd/swapcli/main.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y21kL3N3YXBjbGkvbWFpbi5nbw==) | `49.16% <33.33%> (ø)` | | | [pricefeed/pricefeed.go](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHJpY2VmZWVkL3ByaWNlZmVlZC5nbw==) | `50.00% <33.33%> (-3.25%)` | :arrow_down: | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/AthanorLabs/atomic-swap/pull/493/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.