search

AthanorLabs / atomic-swap

💫 ETH-XMR atomic swap implementation
GNU Lesser General Public License v3.0
345 stars 44 forks source link

Use prettier@2.8.8 instead of latest version for solidity formatting #500

Closed stubbrn closed 1 year ago

stubbrn commented 1 year ago

Some breaking change in prettier 3.0.0 (published to npm 3 days ago) made make format return errors:

[error] No parser could be inferred for file "atomic-swap/ethereum/block/testdata/UTContract.sol".
[error] No parser could be inferred for file "atomic-swap/ethereum/contracts/AggregatorV3Interface.sol".
[error] No parser could be inferred for file "atomic-swap/ethereum/contracts/TestERC20.sol".
[error] No parser could be inferred for file "atomic-swap/ethereum/contracts/Secp256k1.sol".
[error] No parser could be inferred for file "atomic-swap/ethereum/contracts/SwapCreator.sol".

This PR updates the checks github workflow (and the documentation) to use prettier@2.8.8 instead of prettier's latest stable version.

dimalinux commented 1 year ago

The PR is good, but superseded by https://github.com/AthanorLabs/atomic-swap/pull/502 that makes the same fix.