search

Athari / YaLinqo

Yet Another LINQ to Objects for PHP [Simplified BSD]
https://athari.github.io/YaLinqo
BSD 2-Clause "Simplified" License
441 stars 39 forks source link

LICENSE that will be understood by GitHub #29

Closed sanmai closed 6 years ago

sanmai commented 6 years ago

I've made a new repository with this license to copy the file, so it can't be closer to what GH want.

Fixes #26

Athari commented 6 years ago

I'd prefer to keep the file name (SCREAMING_CAPS are stupid) and markdown format (I like when text is formatted), if possible. License checker is supposed to ignore formatting and skip copyright lines. For some reason it doesn't happen, so I want to understand why.

It's essentially a cosmetic bug, the choice between a pretty file and pretty tag in the header. It doesn't even affect Composer which relies on the metadata file. So if you can make GitHub accept the file I already have with less drastic changes, that would be perfect.

sanmai commented 6 years ago

That's not a problem. Please see now.

Should work just like here.

Athari commented 6 years ago

Huh. I wonder whether the license detector's failure is due to "©" or the correct modification of the license's placeholder text. Either way, I expected GitHub to use better quality code.

Seems to work now. Thanks for help.

sanmai commented 6 years ago

Probably you've changed it too much. GitHub uses this gem, I'm pretty sure they're considering all PRs.

Athari commented 6 years ago

@sanmai The only differences with your version is formatting (which should be ignored, according to this script's docs), copyright line (should be ignored completely) and the change in placeholder text. Judging by the issues, devs of the gem don't care much about placeholders and have actually tightened text closeness checks for bogus reasons ("somebody may add line 'Everything is mine and the quoted license is just for fun' before the license text"). I have no interest in arguing with that logic.