Atharv-Attri / HacktoberFest-Projects

A collection of issues for Hacktoberfest!
MIT License
6 stars 27 forks source link

added new project #40

Closed eswarupkumar closed 3 years ago

eswarupkumar commented 3 years ago

Build a JS Project i.e stone paper scissor game.

Atharv-Attri commented 3 years ago

You literally deleted every single other file. I will mark this PR as invalid, please create a new one that does not remove these files. Other than that, I'm more than happy to merge!

Atharv-Attri commented 3 years ago

Actually, I won't mark it as invalid, I don't want you to get a strike, I'll talk to Matt and see if there is a way I can have this PR not count and still not get you a strike

Atharv-Attri commented 3 years ago

Hey, turns out there was an error on the repo that was causing it, can you please re-clone and then add in your files. Sorry for the inconvenience

eswarupkumar commented 3 years ago

Okay sure. I didn't delete any. There was problem in cloning maybe.

On Fri, Oct 9, 2020, 10:03 AM Atharv Attri notifications@github.com wrote:

Hey, turns out there was an error on the repo that was causing it, can you please re-clone and then add in your files. Sorry for the inconvenience

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Atharv-Attri/HacktoberFest-Projects/pull/40#issuecomment-705962069, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKQX6D6QZ6DEPND5LSJ4MZDSJ2HCVANCNFSM4SJGHTKQ .

Atharv-Attri commented 3 years ago

Yes, one of the folder names had a space in it, so it was causing errors in git

eswarupkumar commented 3 years ago

Unable to clone any files present in the repo. I used the git clone command and after I did there is no file present inside.

On Fri, Oct 9, 2020, 10:08 AM Atharv Attri notifications@github.com wrote:

Yes, one of the folder names had a space in it, so it was causing errors in git

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Atharv-Attri/HacktoberFest-Projects/pull/40#issuecomment-705963191, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKQX6D6OQ3FWSCPX2G6ETLTSJ2HU5ANCNFSM4SJGHTKQ .

Atharv-Attri commented 3 years ago

IDK why that is happening. Can you try doing it all over again from the start? (even deleting the fork)

eswarupkumar commented 3 years ago

Thanks. Did what you said. Have a look .

On Fri, Oct 9, 2020, 10:26 AM Atharv Attri notifications@github.com wrote:

IDK why that is happening. Can you try doing it all over again from the start? (even deleting the fork)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Atharv-Attri/HacktoberFest-Projects/pull/40#issuecomment-705967461, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKQX6D3QJFD7KC64XMNEDCTSJ2JYVANCNFSM4SJGHTKQ .

Atharv-Attri commented 3 years ago

Well, You are lucky, since I have this repo labeled as hacktoberfest, there is no way I can close this repo without it going against your spam counter, so you get a free PR!

eswarupkumar commented 3 years ago

Thank you. This will count as PR for hacktober fest. Isn't?

On Fri, Oct 9, 2020, 10:37 AM Atharv Attri notifications@github.com wrote:

Closed #40 https://github.com/Atharv-Attri/HacktoberFest-Projects/pull/40.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Atharv-Attri/HacktoberFest-Projects/pull/40#event-3858460462, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKQX6DZPCF7KV63RMCGYJ2TSJ2LCZANCNFSM4SJGHTKQ .

Atharv-Attri commented 3 years ago

Yes it will.