search

AtheMathmo / rulinalg

A linear algebra library written in Rust
https://crates.io/crates/rulinalg
MIT License
288 stars 58 forks source link

Document that Cholesky only uses the lower triangular part #188

Open vks opened 7 years ago

vks commented 7 years ago

This informs the user that it is possible to only initialize the lower triangular part, saving a few operations.

Andlon commented 7 years ago

Yes, this makes sense - on the other hand, if we provide that guarantee we cannot easily change our minds later, because changing this behavior would subtly break user's code without warning (since there are no API breakages or similar).

I am planning to rewrite the Cholesky decomposition to use BLAS-3 in the future, and I can't say for sure if we'd still only access the lower triangular part then - but I think so. I suggest we keep this issue open and revisit when we are more confident in providing such a guarantee.