search

AtheMathmo / rusty-machine

Machine Learning library for Rust
https://crates.io/crates/rusty-machine/
MIT License
1.25k stars 152 forks source link

example: classifying dogs with a naïve Bayes model #131

Closed zackmdavis closed 8 years ago

zackmdavis commented 8 years ago

This in the matter of #128.

zackmdavis commented 8 years ago

... except that CI doesn't know that the example needs the stats feature (see discussion on #130).

AtheMathmo commented 8 years ago

I love the context for the example! I have a few comments for the example code. I think it needs some more inline comments and hand holding. Maybe we can try to separate out the data-creation and the machine learning parts too. But really it only needs some mild changes.

I guess the bigger issue is the feature flag... I'll see if I can find a way to fix that using the stats feature (maybe we can hide the example behind the feature flag?). Otherwise it might be best to just use the rand crate here for the Gaussians?

zackmdavis commented 8 years ago

OK; sometime in the next few days I'll add comments and change it to use rand::distributions::normal::Normal

AtheMathmo commented 8 years ago

OK; sometime in the next few days I'll add comments and change it to use rand::distributions::normal::Normal

Great, thank you!

I've merged in #133 which has some breaking changes (going into the 0.5.0 release). Let me know if you need any help resolving. It's mostly modifications to trait imports and some behind-the-scenes naive bayes changes (shouldn't affect you).

zackmdavis commented 8 years ago

(updated and force-pushed)

zackmdavis commented 8 years ago

OK; more commentary later

AtheMathmo commented 8 years ago

@zackmdavis did you need anything from me for this?

Not rushing you at all - take as long as you like!

zackmdavis commented 8 years ago

Alternatively, merge now and accept improvements later if I (or—we can unrealistically hope—someone else) happen to get around to it??