AthenZ / k8s-athenz-sia

Apache License 2.0
1 stars 7 forks source link

Treat IP Address as an optional parameter #117

Closed ctyano closed 4 months ago

ctyano commented 5 months ago

Description

IP addresses in X.509 Subject Alternative Names is an optional attribute in Athenz X.509 identity certificate. Users shall set an empty string to POD_IP environment variable to remove IP address from a CSR. If the IP address is not set in the CSR, ZTS will skip verifying the client IP address to match the SANs IP. (e.g. InstanceZTSProvider)

Assignees

Type of changes

Flags

Checklist

Checklist for maintainer

mlajkim commented 5 months ago

Please modify the athenz-sia.env file too.

mlajkim commented 5 months ago

@ctyano Do you think we should merge this before the release of v3.2.0?

mlajkim commented 5 months ago

~This requires operation check just in case in k8s platform.~ ~TODOs:~ ~-[x] Operation done by @mlajkim~

I won't do it as I wrote this with expectation of including this PR in v3.2.0.

mlajkim commented 5 months ago

This won't be included in v3.2.0 release.