AthenZ / k8s-athenz-sia

Apache License 2.0
1 stars 7 forks source link

Fix condition for `r.pollRefresh()` #118

Closed mlajkim closed 5 months ago

mlajkim commented 5 months ago

Description

r.pollRefresh() must run only when the following condition all met:

But current code only checks config.ProviderService == "", and it is a bug.

Reference:

Assignees

Type of changes

Flags

- [ ] Breaks backward compatibility
- [ ] Requires a documentation update
- [ ] Has untestable code

Checklist

- [ ] Followed the guidelines in the CONTRIBUTING document
- [ ] Added prefix `[skip ci]`/`[ci skip]`/`[no ci]`/`[skip actions]`/`[actions skip]` in the PR title if necessary
- [ ] Tested and linted the code
- [ ] Commented the code
- [ ] Made corresponding changes to the documentation

Checklist for maintainer

- [ ] Use `Squash and merge`
- [ ] Double-confirm the merge message has prefix `[skip ci]`/`[ci skip]`/`[no ci]`/`[skip actions]`/`[actions skip]`
- [ ] Delete the branch after merge
mlajkim commented 5 months ago

Issue created for a potential refactor here: https://github.com/AthenZ/k8s-athenz-sia/issues/119