AthenZ / k8s-athenz-sia

Apache License 2.0

1 stars 7 forks source link

Refactor derived-role-cert with `Format` & `KeyFormat` #148

Closed mlajkim closed 3 days ago

mlajkim commented 4 days ago

Description

Refactored derivedRoleCertConfig() to utilize the function GeneratePath() introduced in https://github.com/AthenZ/k8s-athenz-sia/pull/141 Also has added some comments for TODOs

Assignees

[x] Assignees is set

Type of changes

[x] Apply one or more labels of the following that fits:
- bug: Bug fix
- dependencies: Dependency upgrades
- documentation: Documentation changes
- enhancement: New Feature
- good first issue: First contribution
- logging: Log changes
- refactor: Refactoring (no functional changes, no api changes)

Flags

- [ ] Breaks backward compatibility
- [ ] Requires a documentation update
- [ ] Has untestable code

Checklist

- [ ] Followed the guidelines in the CONTRIBUTING document
- [ ] Added prefix `[skip ci]`/`[ci skip]`/`[no ci]`/`[skip actions]`/`[actions skip]` in the PR title if necessary
- [ ] Tested and linted the code
- [ ] Commented the code
- [ ] Made corresponding changes to the documentation

Checklist for maintainer

- [ ] Use `Squash and merge`
- [ ] Double-confirm the merge message has prefix `[skip ci]`/`[ci skip]`/`[no ci]`/`[skip actions]`/`[actions skip]`
- [ ] Delete the branch after merge