AthenZ / k8s-athenz-sia

Apache License 2.0
1 stars 7 forks source link

Default values should be carefully selected #44

Closed mlajkim closed 6 months ago

mlajkim commented 10 months ago

Background

Default value like DELETE_INSTANCE_ID=true is wrong as it requires athenz permission and outputting error message without permission isn't the best

TODOs

- [ ] Check the default values
- [ ] Check if every env must be modifiable under Makefile
WindzCUHK commented 10 months ago

Deleting the instance certificate should be the default behavior because of the following:

I think the focus should be the error message.