AthenZ / k8s-athenz-sia

Apache License 2.0

1 stars 7 forks source link

split key default to false #46

Closed WindzCUHK closed 10 months ago

WindzCUHK commented 10 months ago

Description

ROLE_CERT_KEY_FILE_OUTPUT default value: true => false

warn user for problematic cases

WARNING[2023-10-25T16:01:46+09:00] Rotating KEY_FILE[./my.private.key.pem] may cause key mismatch with issued role certificate due to different rotation cycle. Please manually restart SIA when you rotate the key file.

improve shutdown msg

^C
INFO[2023-10-26T10:06:10+09:00] Initiating shutdown with received signal interrupt ...
INFO[2023-10-26T10:06:10+09:00] Initiating shutdown of certificate provider daemon ...
INFO[2023-10-26T10:06:10+09:00] Initiating shutdown of token provider daemon ...
INFO[2023-10-26T10:06:10+09:00] Initiating shutdown of metrics exporter daemon ...
INFO[2023-10-26T10:06:10+09:00] Shutdown completed!

Type of change

[x] Bug fix
[ ] New feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Non-code changes (update documentation, pipeline, etc.)

Flags

[ ] Breaks backward compatibility
[ ] Requires a documentation update
[ ] Has untestable code

Related issue/PR

Fixes #42
Fixes #41

Checklist

[x] Followed the guidelines in the CONTRIBUTING document
[x] Added prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip] in the PR title if necessary
[x] Tested and linted the code
[x] Commented the code
[x] Made corresponding changes to the documentation
[ ] Passed all pipeline checking

Checklist for maintainer

Use Squash and merge
Double-confirm the merge message has prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]
Delete the branch after merge

mlajkim commented 10 months ago

@WindzCUHK Will review it tomorrow on Oct 26

WindzCUHK commented 10 months ago

@mlajkim

No Makefile?

Replied in https://github.com/AthenZ/k8s-athenz-sia/issues/42#issuecomment-1778644098 Can we skip it in this PR, and continue the discussion in https://github.com/AthenZ/k8s-athenz-sia/issues/47?