AthenZ / k8s-athenz-sia

Apache License 2.0

1 stars 7 forks source link

Makefile with all environment variables available #47

Open mlajkim opened 10 months ago

mlajkim commented 10 months ago

Background

https://github.com/AthenZ/k8s-athenz-sia/blob/main/Makefile#L21-L53 Makefiles should handle all environment variables available.

WindzCUHK commented 10 months ago

It maybe too clumsy to simply allow all default values to be customizable with the Makefile. (although it is easy to design)

I think we can determine by whether it is appropriate to print the value by the version command. https://github.com/AthenZ/k8s-athenz-sia/blob/6b5a2313d0f9460467618f66fc845e74c2c411de/cmd/athenz-sia/main.go#L37