AthenZ / k8s-athenz-sia

Apache License 2.0

1 stars 7 forks source link

add tag to git submodule #73

Open WindzCUHK opened 8 months ago

WindzCUHK commented 8 months ago

Description

git submodule does support tag by default. Add make submodule-use-tag to allow using submodule with tag.

Type of change

[ ] Bug fix
[ ] New feature
[x] Refactoring (no functional changes, no api changes)
[ ] Non-code changes (update documentation, pipeline, etc.)

Flags

[ ] Breaks backward compatibility
[ ] Requires a documentation update
[ ] Has untestable code

Checklist

[x] Followed the guidelines in the CONTRIBUTING document
[x] Added prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip] in the PR title if necessary
[x] Tested and linted the code
[x] Commented the code
[x] Made corresponding changes to the documentation
[x] Passed all pipeline checking

Checklist for maintainer

Use Squash and merge
Double-confirm the merge message has prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]
Delete the branch after merge

mlajkim commented 8 months ago

note: Hmm not sure if managing version as fixed string, when you can clearly see what version it is, is not really important possibly