Athena-OS / athena

Athena OS is a Arch/Nix-based distro focused on Cybersecurity. Learn, practice and enjoy with any hacking tool!
https://athenaos.org
MIT License
1.03k stars 78 forks source link

[BUG]: Updates causing unwanted changes to GRUB config on dual-boot system #86

Closed munkinut closed 10 months ago

munkinut commented 10 months ago

Athena OS version

Athena OS Polias

Which environment or technology are you using?

Kernel version

6.5.10-hardened1-1-hardened

Involved software

GRUB

Repro steps

Create a dual-boot with Debian as the other Linux OS (use Debian expert installer to skip GRUB installation). Use Grub Customizer to add in the Debian OS to GRUB. Save the config and write to MBR. Test that both OS's appear when rebooting, and can be started through GRUB. Boot into Athena OS, perform an update of Athena OS. The updater overwrites the GRUB config, leaving only the Entries for Athena OS (the Debian ones are missing).

Expected behavior

Athena OS updater should edit the GRUB config in such a way as to preserve the entries added by GRUB Customizer during the process of setting up the dual-boot configuration.

Actual behavior

Entries in GRUB config are not preserved during an update of Athena OS. Rebooting after an update shows that (where new entries had been added) entries are now missing.

Diagnostic logs

No response

D3vil0p3r commented 10 months ago

Fixed mkinitcpio hooks and changed the logic to trigger the GRUB update. A sudo pacman -Syyu should be enough.