AthenaEPI / dmipy

The open source toolbox for reproducible diffusion MRI-based microstructure estimation
MIT License
96 stars 30 forks source link

fix syntax error #101

Closed matteofrigo closed 4 years ago

matteofrigo commented 4 years ago

A wrong string formatting was generating an unexpected error. The problem is now fixed.

This PR solves issue #100 .

codecov-commenter commented 4 years ago

Codecov Report

Merging #101 into master will increase coverage by 0.06%. The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   82.79%   82.86%   +0.06%     
==========================================
  Files          67       67              
  Lines        5860     5871      +11     
  Branches      695      696       +1     
==========================================
+ Hits         4852     4865      +13     
+ Misses        819      818       -1     
+ Partials      189      188       -1     
Impacted Files Coverage Δ
...mipy/distributions/tests/test_distribute_models.py 98.86% <90.90%> (-1.14%) :arrow_down:
dmipy/distributions/distribute_models.py 73.04% <100.00%> (+0.69%) :arrow_up:
dmipy/distributions/tests/test_bingham.py 91.04% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9bd7038...0878f63. Read the comment docs.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 706


Files with Coverage Reduction New Missed Lines %
dmipy/distributions/tests/test_bingham.py 4 86.3%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 704: 0.0009%
Covered Lines: 5053
Relevant Lines: 5871

💛 - Coveralls
rutgerfick commented 4 years ago

I notice you also added a test? so it's more than just fixing a sytax error?

matteofrigo commented 4 years ago

I added a test to increase the coverage, otherwise it's not going to merge it