AthenaEPI / dmipy

The open source toolbox for reproducible diffusion MRI-based microstructure estimation
MIT License
96 stars 30 forks source link

Multi tissue tortuosity #110

Closed matteofrigo closed 3 years ago

matteofrigo commented 3 years ago

The multi-tissue correction is triggered as follows:

    model.set_tortuous_parameter(
        lambda_perp_parameter_name,
        lambda_par_parameter_name,
        volume_fraction_intra_parameter_name,
        volume_fraction_extra_parameter_name,
        S0_correction=True
    )

where the trigger is the S0_correction=True. The used S0 is the one passed to the constructor of the model.

Limitations

The stick and the zeppelin must both be at the top level of the model.

Example of admissible model:

ball = gaussian_models.G1Ball()
stick = SD1WatsonDistributed([cylinder_models.C1Stick()])
zeppelin = SD1WatsonDistributed([gaussian_models.G2Zeppelin()])
model = MultiCompartmentModel(models=[stick, zeppelin, ball], S0_tissue_responses=[s0_stick, s0_zeppelin, s0_ball])

This PR replaces #84 .

codecov-io commented 3 years ago

Codecov Report

Merging #110 (86a0a44) into master (21c3efc) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   82.86%   82.86%           
=======================================
  Files          67       67           
  Lines        5871     5871           
  Branches      696      696           
=======================================
  Hits         4865     4865           
  Misses        817      817           
  Partials      189      189           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21c3efc...86a0a44. Read the comment docs.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 727


Totals Coverage Status
Change from base Build 726: 0.0%
Covered Lines: 5054
Relevant Lines: 5871

💛 - Coveralls