AthenaEPI / dmipy

The open source toolbox for reproducible diffusion MRI-based microstructure estimation
MIT License
96 stars 30 forks source link

Tournier12 White Matter Response Function Estimation #19

Closed rutgerfick closed 6 years ago

rutgerfick commented 6 years ago
coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 309


Changes Missing Coverage Covered Lines Changed/Added Lines %
dmipy/core/fitted_modeling_framework.py 22 29 75.86%
dmipy/optimizers_fod/csd_cvxpy.py 4 11 36.36%
dmipy/tissue_response/white_matter_response.py 49 58 84.48%
dmipy/tissue_response/three_tissue_response.py 10 39 25.64%
<!-- Total: 167 219 76.26% -->
Files with Coverage Reduction New Missed Lines %
dmipy/data/saved_data.py 2 70.94%
dmipy/distributions/tests/test_bingham.py 2 93.15%
dmipy/data/saved_acquisition_schemes.py 2 83.33%
dmipy/utils/tests/test_spherical_convolution.py 4 88.37%
<!-- Total: 10 -->
Totals Coverage Status
Change from base Build 266: -0.8%
Covered Lines: 4338
Relevant Lines: 5099

💛 - Coveralls
codecov-io commented 6 years ago

Codecov Report

Merging #19 into master will decrease coverage by 0.04%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   83.22%   83.18%   -0.05%     
==========================================
  Files          55       55              
  Lines        4824     4824              
  Branches      543      543              
==========================================
- Hits         4015     4013       -2     
- Misses        667      668       +1     
- Partials      142      143       +1
Impacted Files Coverage Δ
dmipy/distributions/tests/test_bingham.py 95.52% <0%> (-2.99%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 64b4985...e0352c3. Read the comment docs.

rutgerfick commented 6 years ago

fix peaks estimator.

rutgerfick commented 6 years ago

seems to work, add small test for tournier07 and some parts of 3 tissue algorithm and merge.

rutgerfick commented 6 years ago

Update 3 tissue response catches