rutgerfick
commented
5 years ago Awesome work @maurozucchelli! The code is already in quite good shape!
I will add specific comments in the code, but as some general suggestions:
- make your code pep8 (remove double empty lines when necessary, unused variables, max line length etc.)
- when in doubt with how to code a certain code segment, look to the google style guide
I'm very excited for this PR! Let's get this baby in perfect shape!
This is the invariants pull request implementing the soon to be published rotation invariants feature for dMRI data.
The goal of this function is to have SH coefficients (as a multidimensional numpy array) and the list of desired invariants as input and it returns the invariants.
Accessory function computes SH coefficients from data with Laplace-Beltrami regularization and another function calculates the list of algebraically independent invariants given the SH order.