AthenaEPI / dmipy

The open source toolbox for reproducible diffusion MRI-based microstructure estimation
MIT License
96 stars 30 forks source link

FIX: pass scheme to call of MultiCompartmentSphericalHarmonicsModel #85

Closed matteofrigo closed 4 years ago

matteofrigo commented 4 years ago

This commit changes the behaviour of the simulate_signal and the __call__ function of instances of the MultiCompartmentSphericalHarmonicsModel class by changing the _construct_convolution_kernel method.

Before this commit, the acquisition scheme employed by the method was the one contained in the self.scheme attribute. After applying this commit, the employed acquisition scheme is the one passed as the keyword argument acquisition_scheme= to the method. If it is not passed, the function will use the one contained in self.scheme for backward compatibility.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 599


Files with Coverage Reduction New Missed Lines %
dmipy/distributions/tests/test_bingham.py 1 95.89%
dmipy/utils/tests/test_spherical_convolution.py 1 95.35%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 594: -0.2%
Covered Lines: 4699
Relevant Lines: 5545

💛 - Coveralls
codecov-io commented 4 years ago

Codecov Report

Merging #85 into master will decrease coverage by 0.06%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage    81.7%   81.64%   -0.07%     
==========================================
  Files          64       64              
  Lines        5543     5545       +2     
  Branches      655      656       +1     
==========================================
- Hits         4529     4527       -2     
- Misses        840      842       +2     
- Partials      174      176       +2
Impacted Files Coverage Δ
dmipy/core/modeling_framework.py 71.21% <100%> (+0.05%) :arrow_up:
dmipy/utils/tests/test_spherical_convolution.py 95.12% <0%> (-4.88%) :arrow_down:
dmipy/distributions/tests/test_bingham.py 95.52% <0%> (-2.99%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7706409...7af3ca5. Read the comment docs.