AthenaEPI / dmipy

The open source toolbox for reproducible diffusion MRI-based microstructure estimation
MIT License
96 stars 30 forks source link

Adds spherical harmonics distributed model to MC approach. #86

Closed rutgerfick closed 4 years ago

rutgerfick commented 4 years ago
coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 694


Changes Missing Coverage Covered Lines Changed/Added Lines %
dmipy/tissue_response/white_matter_response.py 0 1 0.0%
dmipy/distributions/distribute_models.py 21 23 91.3%
dmipy/core/modeling_framework.py 25 29 86.21%
dmipy/distributions/distributions.py 14 22 63.64%
<!-- Total: 84 99 84.85% -->
Files with Coverage Reduction New Missed Lines %
dmipy/core/fitted_modeling_framework.py 1 69.72%
dmipy/optimizers/brute2fine.py 1 86.21%
dmipy/distributions/tests/test_bingham.py 4 86.3%
<!-- Total: 6 -->
Totals Coverage Status
Change from base Build 675: 0.7%
Covered Lines: 4800
Relevant Lines: 5616

💛 - Coveralls
codecov-io commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2f109e8). Click here to learn what that means. The diff coverage is 32.6%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #86   +/-   ##
=========================================
  Coverage          ?   81.35%           
=========================================
  Files             ?       64           
  Lines             ?     5579           
  Branches          ?      661           
=========================================
  Hits              ?     4539           
  Misses            ?      866           
  Partials          ?      174
Impacted Files Coverage Δ
dmipy/distributions/distribute_models.py 66.66% <17.39%> (ø)
dmipy/distributions/distributions.py 91.62% <30%> (ø)
dmipy/core/modeling_framework.py 71.39% <61.53%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f109e8...1557fe1. Read the comment docs.

codecov-commenter commented 4 years ago

Codecov Report

Merging #86 into master will increase coverage by 0.68%. The diff coverage is 75.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   81.60%   82.28%   +0.68%     
==========================================
  Files          64       64              
  Lines        5549     5616      +67     
  Branches      658      667       +9     
==========================================
+ Hits         4528     4621      +93     
+ Misses        845      811      -34     
- Partials      176      184       +8     
Impacted Files Coverage Δ
dmipy/tissue_response/white_matter_response.py 72.15% <0.00%> (ø)
dmipy/distributions/distributions.py 91.09% <59.09%> (-4.17%) :arrow_down:
dmipy/core/modeling_framework.py 72.41% <68.96%> (+1.49%) :arrow_up:
dmipy/distributions/distribute_models.py 72.22% <78.26%> (+2.87%) :arrow_up:
...s/test_csd_equivalence_parametric_distributions.py 100.00% <100.00%> (ø)
dmipy/optimizers/brute2fine.py 82.41% <100.00%> (-1.10%) :arrow_down:
dmipy/optimizers_fod/csd_cvxpy.py 89.13% <100.00%> (+0.11%) :arrow_up:
.../tissue_response/tests/test_tissue_response_csd.py 100.00% <100.00%> (ø)
dmipy/core/fitted_modeling_framework.py 67.11% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 32f5174...dd67c3e. Read the comment docs.