Mix fixes in the project

AthenaEventEngine / AthenaCore

Athena Event Engine Core

GNU General Public License v3.0

16 stars 20 forks source link

Mix fixes in the project #154

Closed ghost closed 8 years ago

ghost commented 8 years ago

Don't merge till I tell that it's finished please. :+1:

fissban commented 8 years ago

Es conveniente usar acentos en esto? Creo q el cliente no es capaz de mostrarlos o si?

ghost commented 8 years ago

La codificación UTF-8 creo que no lo contempla, tendré que ver más tarde si se pueden "imitar" para no tener problemas de caracteres extraños. De todas formas algo hay que hacer, porque si se quiere poner ésto en los distintos idiomas... (dígase francés, alemán, etc, etc) dará problemas igualmente.

ghost commented 8 years ago

Con ésto se van a solventar los posibles problemas ISO-8859-1 Lo apunto aquí para que no se me pase añadirlo después.

fissban commented 8 years ago

El twma es q alguna de estas cosas son mostradas en html y otras no asiq eso es oo q oo vomplica

ghost commented 8 years ago

@fissban Mirad a ver si da problemas ahora, please. Gracias.

ghost commented 8 years ago

He terminado con éste PR. @fissban 1000 disculpas por mi pequeña metedura de pata. Saludos.

ghost commented 8 years ago

@luksdlt92 && @u3games editaré los parámetros principales del proyecto y volveré a la carga dentro de unos días. Esto no se va a quedar así 😄...

No mergeéis aún ésto

Lucheti29 commented 8 years ago

@Sacrifice78 Okei

Lucheti29 commented 8 years ago

@Sacrifice78 17 commits?!?!?!? What the hell is this? Please, add a description to the PR and squash/merge the commits.

ghost commented 8 years ago

Seems to be that work outside of eclipse is a shit...

I will do a squash in eclipse and in commit I will write a description of all changes, dont worry.

Dont merge it. I will do it when done.

u3games commented 8 years ago

Thx @Sacrifice78, is best create PR for eatch changes or unite reviews.

ghost commented 8 years ago

@u3games totally agree with you. Also with @luksdlt92 ofc. The thing is that when I go navigate across the project (reading from one method for example), I go found things wrong and I go fixing "practically on the fly", that's the reason for all this commits, others are for my errors (I also have errors... im not perfect) trying to edit files outside eclipse (CR's & LF's over all). Another thing is do a commit to close an issue, in this case, the issue will be closed via commit. Till this, I can undersand to be logic. Probably when all project issues be fixed, then with just only one commit be sufficient. On the other hand, i respect all your comments, it will always be so. Soon bugs reported will can fixed quickly, but first project must be the most refined that can be.

u3games commented 8 years ago

Nice @Sacrifice78 ^^