Atheos / Atheos

A self-hosted browser-based cloud IDE, updated from Codiad IDE
https://www.atheos.io/
492 stars 76 forks source link

Terminal plugin #111

Closed swatrigant closed 4 years ago

swatrigant commented 4 years ago

Hello !

I really want to use the Terminal plugin, but can't make it work because it is still the "old" plugin, the Codiad one, and I'm having a hard time updating it. Do you think you could work on updating this particular plugin ?

I fully understand if it is not a priority right now, or if you don't have time to work on that issue ! I think it is amazing how quickly you react to any issue, thank you !

HLSiira commented 4 years ago

Let me see what I can work out. Have you used the plugin before on Codiad?

If I recall correctly, it was a little clunky so I can probably get it working soon but it might not be much better than it was until I spend some rime cleaning it

swatrigant commented 4 years ago

Yes, it was a little it old-fashion on Codiad, but it will do (at least for me). I was thinking about making it work (but I can't, which is why I opened a new issue) and then later maybe making it look more modern !

Thanks again !

HLSiira commented 4 years ago

If I may ask, what are you getting hung up on?

HLSiira commented 4 years ago

Hey @swatrigant,

I got it updated and pushed to the master repo, but I highly suggest you pull from the development repo of Atheos in order to ensure that you're working with the latest source as that's what I run and made it work with Terminal.

I offer no promises that it will work perfectly since I just kind of did a quick copy-paste of the original codiad repo and all it's pull requests, merging with zero checks. I haven't tested everything yet but as far as I can tell, no bugs.

I also went a little too into the styling side of the terminal since I wanted to; hopefully you're into the style.

Let me know what you think or any bugs or errors you have.

swatrigant commented 4 years ago

Thank you so much ! I am going to look at all of that right now !