search

Atheos / Atheos

A self-hosted browser-based cloud IDE, updated from Codiad IDE
https://www.atheos.io/
492 stars 76 forks source link

Tabs drag n drop doesn't work properly #202

Closed tchavot closed 2 years ago

tchavot commented 3 years ago

Describe the bug Dragging and dropping tabs creates many display bugs as you can see an example below (cursor has been released): 2021-08-17 17_27_34-Atheos IDE

Desktop (please complete the following information):

HLSiira commented 3 years ago

Looks like it's not removing the ghost tab used for the drag/drop mechanism, I'll dig around and see what I can find. It happens in the file manager as well and I haven't figured out why.

Thank you for letting me know, I'll try to fix it as soon as I can, although I'm swamped in other projects, so I hope you don't mind me taking a little bit of time.

tchavot commented 3 years ago

Thank you, your commit fixed the bug!

HLSiira commented 3 years ago

No problem, let me know if you run into anything else, I dev mostly on Chrome so I miss a lot of the oddities of Firefox.

tchavot commented 3 years ago

Hey @HLSiira it seems that it broke the drag n drop behavior in the file manager... Can't drag n drop a file in a directory! Browser: Firefox.

HLSiira commented 3 years ago

Merp. I thought I'd try to head that off and fix that issue, I'll look into and see what shows up. Have you run into any other issues on FX?

tchavot commented 3 years ago

For now I can see no more issues with FF. But please note that the issue mentioned here concerns both Firefox and Safari!

HLSiira commented 3 years ago

Sweet, thank you for letting me know. I mostly develop on Chrome, but I'll try to be better about testing on FF/Safari more often.

tchavot commented 3 years ago

@HLSiira Unfortunatly the issue is still not fixed. I can't drag n drop any file in the file manager when I use either Firefox or Safari.

HLSiira commented 2 years ago

@tchavot I've built a server using PHP8 just to verify and can't reproduce this bug on any browser. Please let me know if there are any error messages, update any caches and use the most recent push to dev if possible. Any information is appreciated!

tchavot commented 2 years ago

Okay I get it. I tried to drop a file on a folder name and it doesn't work. But if I open the folder first and then I drop the file amidst the folder content, then it works! Thanks.

HLSiira commented 2 years ago

Yeah I've trying to figure out a way to make it so that will happen more naturally, but I'm not creative enough to think of a nice way to set it up with making stuff really complicated. It irritates me.

3642066 commented 2 years ago

That bug happens on codiad since when codiad was........ it called ...

HLSiira commented 2 years ago

Problem is that almost none of the source is Codiad anymore. Heck, I don't think the Drag and Drop feature from Codaid was actually Codiad, IIRC it used a jQuery plugin. Atheos is almost all in house coded except for the Ace Editor I think.