Closed manifest closed 5 years ago
I've also changed the type of keep_alive option to u64 since it is expected by Duration constructor and to make it symmetrical to other options using time intervals in seconds as reconnect.
Thank you :)
@tekjar Could we bump a new crate version? We need this change in another crate, so we can't use branch or just depend on the commit there.
Ahh, I'm not sure if there are any breaking changes in the master branch since the last release. Can you let me know if there are any? I'll do minor increment if not
Can you let me know if there are any?
There is none of breaking changes as far as I can see. We can go with update of the minor version.
Looks like this is breaking a bunch of tests and examples. I might have missed the CI here. We have to revert this
I'll revert this now. I need some consensus on builder patterns. Can you use this for now?
let mut opts = rumqtt::MqttOptions::new(client_id, host, port.as_u16());
let opts = if let Some(value) = config.clean_session {
opts.set_clean_session(value)
} else {
opts
}
Ok(opts)
The following code fails because the current implementation of setters require implementation of
Copy
trait.