AtherEnergy / rumqtt

Pure rust mqtt cilent
The Unlicense
203 stars 72 forks source link

Hitting unimplemented!() #149

Open bestouff opened 5 years ago

bestouff commented 5 years ago

I'm hitting unimplemented!() in this function, in src/client/mqttstate.rs (line 71):

    pub fn handle_outgoing_mqtt_packet(&mut self, packet: Packet) -> Result<Request, NetworkError> {
        let out = match packet {
            Packet::Publish(publish) => {
                let publish = self.handle_outgoing_publish(publish)?;
                Request::Publish(publish)
            }
            Packet::Pingreq => self.handle_outgoing_ping()?,
            Packet::Subscribe(subs) => {
                let subscription = self.handle_outgoing_subscribe(subs)?;
                Request::Subscribe(subscription)                                                                        
            }
            _ => unimplemented!(),
        };

... right when unsubscribing/resubscribing a topic.

tekjar commented 5 years ago

As you've noted, unsubscribe isn't implemented yet. I'll take this up in June

bestouff commented 5 years ago

That's OK, let this issue live as a tracker for this feature.

rcastill commented 4 years ago

Hi, is this feature planned for implementation any time soon?

tekjar commented 4 years ago

@rcastill Hi. I’m not working on this repo anymore. I’m not sure if there are any plans on features. Follow the progress of a different implementation in the below repo

https://github.com/tekjar/rumq

rcastill commented 4 years ago

Thanks for the info.

I’d recommend to update the README with a disclaimer pointing that out.

I’ll give the new repo a try!

tekjar commented 4 years ago

I’m not working at Ather anymore but somehow I still have admin permissions :) I don’t feel entitled to change readme though

The new repo is still in alpha and the feature might not be there as well. But the probability that I implement what you need is much higher there