Closed TotalKrill closed 5 years ago
If timeout is set to 1 an error is returned, so one can react, however the eventloop never exits.
Might I ask you to push this change to crates.io? would be very appreciated
Hi. This crate is used in production and my confidence levels are little low now as I've merged a bunch of commits without unit tests and CI. I'm adding these in develop
branch and there are already a bunch of changes. I'll push to crates as soon as I'm done with it
Hey, might be the wrong topic, but since I am watching this repo, I got that you merged the develop branch.
What is missing to bump the version number, I might be able to help
Can you verify if this problem is solved? I've already bumped the version. I'll push it crates day after tomorrow
Ran my tests again, seems to be fine. But to be sure maybe there should be some kind of integration testing. Could also be good for future confidence levels of the system
There are unitests for connection
eventloop as well now. I think there is already a test for this
Trying to connect to an invalid web-address such as braker.hivemq.com are never resolved,
yields![image](https://user-images.githubusercontent.com/3248006/58263004-9671ca80-7d7b-11e9-8834-6e74b50f537b.png)
but the error is never detected and the code continues anyway