search

AthletiFi / athletifi-website

Official website for AthletiFi
https://www.athleti.fi
1 stars 5 forks source link

Create User-Friendly Error Popups #202

Closed chef-louis closed 3 months ago

chef-louis commented 3 months ago

167

chef-louis commented 3 months ago

@qisforq Good catch and thanks for flagging with such detail. I've pushed up a fix for the season highlights component. Let me know if that looks better for you.

We can also talk separately about whether we like the design of these messages or not. I've kept it possibly too simple but would be good to get the thoughts from the group as well.

qisforq commented 3 months ago

Hey @chef-louis just noticed you closed this without merging. Are you planning on adding this into a new PR?

chef-louis commented 3 months ago

Yah I’m going to add a new PR with the updated changes we discussed. Won’t get to it until later tonight so wanted to pull the PR in the meantime.

On Fri, Apr 5, 2024 at 6:00 PM Quentin @.***> wrote:

Hey @chef-louis https://github.com/chef-louis just noticed you closed this without merging. Are you planning on adding this into a new PR?

— Reply to this email directly, view it on GitHub https://github.com/AthletiFi/athletifi-website/pull/202#issuecomment-2040798717, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBNSHMWXS5IFEPSWBZQPN5TY343LBAVCNFSM6AAAAABFWAGVRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQG44TQNZRG4 . You are receiving this because you were mentioned.Message ID: @.***>