search

AthletiFi / athletifi-website

Official website for AthletiFi
https://www.athleti.fi
1 stars 5 forks source link

Test Facebook OAuth integration #228

Closed qisforq closed 1 month ago

qisforq commented 2 months ago

Objective

Test the Facebook OAuth integration to ensure proper functionality.

Sub-tasks

  1. Set up a test users for Facebook OAuth.
  2. Perform end-to-end testing of the Facebook OAuth flow.
  3. Test edge cases and error scenarios.
  4. Document and rectify any identified issues
chef-louis commented 1 month ago

@qisforq I made a test account on facebook under the email: louis.code88@gmail.com. Let me know once this is whitelisted and I'll get it tested. Thanks

qisforq commented 1 month ago

louis.code88@gmail.com.

@chef-louis do you have a fbid or username you can pass me? I'm not able to add by email. I'm going to add you as a developer as well so you can modify the settings if needed

chef-louis commented 1 month ago

@qisforq FB User ID: 122102796122308584. I think that's the right one, but let me know if it gives you any trouble. Alternatively I can try to set it up myself tomorrow.

qisforq commented 1 month ago

@chef-louis that user id didn't seem to work. Can you send me a friend request? https://www.facebook.com/qisforq

chef-louis commented 1 month ago

Sent a request. It's a new account because I deactivated my old one from years ago.

qisforq commented 1 month ago

No problem, I don't use facebook often myself, but it'll be easier to add you if we're friends

qisforq commented 1 month ago

Ahhh wait I see the issue. It wasn't that it couldn't find you (my mistake, I didn't read the error message closely at first)

Image

Form cant be saved You are trying to add users that haven't registered their developer accounts. Tell Louis Code to go to the help center to complete their registration.

chef-louis commented 1 month ago

Ahh okay. Let me do that

chef-louis commented 1 month ago

Okay done

qisforq commented 1 month ago

And you're added!

chef-louis commented 1 month ago

I'm running into some issues with google oauth and handling of redirects (dynamically) but will move onto facebook once this is done. Thanks

chef-louis commented 1 month ago

I can't seem to get to the screen where I can even attempt login with FB. I think I see the issue which is that our OAuth client is configured to include email scope but in the FB developer page, the email permissions for the app are not enabled. I get a generic error message when trying to enable it which is where I am now stuck. Any thoughts? Could it be a permissions problem with my account?

Image Image

chef-louis commented 1 month ago

Finally had some time to get back to this task but unfortunately it looks like creating test users is disabled. I'm not sure if that's for all developer accounts, is this something that you'd be able to try when you have a chance @qisforq?

Image

qisforq commented 1 month ago

I can't seem to get to the screen where I can even attempt login with FB. I think I see the issue which is that our OAuth client is configured to include email scope but in the FB developer page, the email permissions for the app are not enabled. I get a generic error message when trying to enable it which is where I am now stuck. Any thoughts? Could it be a permissions problem with my account?

Image Image

Sorry I did not see this comment before now either (my notification emails keep landing in spam).

Is this still an issue?

chef-louis commented 1 month ago

Attempted another time to debug/fix the root cause of the issue on the developer portal. Unfortunately I wasn't able to get passed the same place at which I was stuck last time. The nondescript message along with FBs relative lack of documentation make it difficult to fully resolve the issue. As of now, I think our last recourse is to remove FB as an oauth provider from our list.

qisforq commented 1 month ago

OBE