AthletiFi / athletifi-website

Official website for AthletiFi
https://www.athleti.fi
1 stars 5 forks source link

Feature Implementation: Invitation Flow for New and Existing Users with Email Notifications #296

Closed HectorAgudelo closed 1 month ago

HectorAgudelo commented 1 month ago

This pull request introduces a new feature that enhances the user invitation flow for our application. Key changes include:

Technical Details:

Additional Notes:

Files Changed:

Functional Testing:

New User Invitation Flow:

Existing User Invitation Flow:

Error Scenarios:

HectorAgudelo commented 1 month ago

@HectorAgudelo just finished reviewing and testing!

Just a couple things:

  1. I did not receive a warning when the invite was already accepted. However I did receive a warning for expired and revoked.
  2. Instead of the status being '1 ALREADY_ACCEPTED', can we change this back to 'ALREADY_ACCEPTED'?

Fixed!

qisforq commented 1 month ago

@HectorAgudelo just finished reviewing and testing! Just a couple things:

  1. I did not receive a warning when the invite was already accepted. However I did receive a warning for expired and revoked.
  2. Instead of the status being '1 ALREADY_ACCEPTED', can we change this back to 'ALREADY_ACCEPTED'?

Fixed!

Awesome thanks @HectorAgudelo! I do not see it here yet, can you push your changes?