[BUG] Post images reload when cell reappears after scrolled off-screen

[boscojwho]

Describe the bug After a post view loads an image, and user scrolls it out of view, the post view will reload that image when that post view's cell reappears.

• Not sure if post view is simply redrawing its state from loading to loaded (i.e. not actually redownloading the image).
• When this happens post view's height will shrink (and show a loading indicator), then expand, which is not ideal.

To Reproduce Steps to reproduce the behavior:

1. Launch app to Feed list view.
2. Wait for First post image to load.
3. Scroll down so first post is just out of view.
4. Scroll back to top.
5. First post's image will reload.

Expected behavior

• Image should stay loaded, unless app receives memory warning, in which case post view still shouldn't be recalculating its height.

Information: Version 0.1 (1)

[Athlon007]

I know of this issue, this is why there is this hacky workaround that retains the height of an image. From what I gathered, it has something to do with LazyVStack and AsyncImage combo.

One solution would likely be switching to normal VStack. This will cost some memory, buuuuut that will fix issues with retention of height and images themselves.

There may be other fixes, but I have not researched them thoroughly.

[boscojwho]

I know of this issue, this is why there is this hacky workaround that retains the height of an image. From what I gathered, it has something to do with LazyVStack and AsyncImage combo.

Indeed: Found this post here with the exact same issue.

• I set a value on URLCache.memoryCapacity/diskCapacity, removed the VStack (not the parent LazyVStack) from one of the AsyncImage instances ("Article View") in PostUIView and it fixed the caching issue.
• The other AsyncImage instance still reloads, gonna do some quick refactoring work here so I can get a clear picture of view hierarchy here XD

[boscojwho]

One solution would likely be switching to normal VStack. This will cost some memory, buuuuut that will fix issues with retention of height and images themselves.

Changing the root view to a VStack doesn't fix the AsyncImage caching issue, and I actually managed to break the layout while doing this, oops.

• Nevermind, I confused this with feed view. We probably should be using List instead, which properly supports cell reuse.

[Athlon007]

Fixed in #33