Adding "on" validation on $_SERVER['HTTPS') variable.

Athlon1600 / php-proxy

A web proxy script written in PHP and built as an alternative to Glype.

https://www.php-proxy.com

MIT License

295 stars 158 forks source link

Closed Payetus closed 4 years ago

Payetus commented 6 years ago

This commit should fix issue #108

Athlon1600 commented 6 years ago

according to PHP docs, $_SERVER['HTTPS'] does not necessarily have to be set to "on" for it to be an HTTPS request:
http://php.net/manual/en/reserved.variables.server.php

From what I understand, as long as server[https] is not empty and not set to "off", then that's an https request. Are you using IIS by any chance?

Payetus commented 6 years ago

Yes, using IIS 8. The $_SERVER['HTTPS'] is set to off (and obviously not empty ) on http requests. Would you attribute this to an IIS bug?

Athlon1600 commented 4 years ago

it's been changed to this now: