Athou / commafeed

Google Reader inspired self-hosted personal RSS reader.
https://www.commafeed.com
Apache License 2.0
2.81k stars 377 forks source link

Punycode domains not working #1588

Closed devvick closed 4 weeks ago

devvick commented 4 weeks ago

Describe the bug I cannot add a URL with punycode domain as feed.

To Reproduce Steps to reproduce the behavior:

  1. Try adding https://xn--gckvb8fzb.com/index.xml as feed.
  2. Error: jakarta.ws.rs.WebApplicationException: マリウス.com: Name or service not known

Expected behavior Able to add a punycode domain as feed

Environment (please complete the following information):

Additional info The domain is resolvable from the same host:

$ drill xn--gckvb8fzb.com
;; ->>HEADER<<- opcode: QUERY, rcode: NOERROR, id: 6792
;; flags: qr rd ra ; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 0 
;; QUESTION SECTION:
;; xn--gckvb8fzb.com.   IN  A

;; ANSWER SECTION:
xn--gckvb8fzb.com.  300 IN  A   143.244.50.83
Athou commented 4 weeks ago

I released 5.3.4 with a fix for this, thank you for the bug report!

devvick commented 4 weeks ago

Thank you, that was incredibly fast :dash: