search

AtilioA / AlertaDoTesouro

🚨 A web application that notifies you about Brazilian treasury bond rates.
GNU General Public License v3.0
4 stars 1 forks source link

Add web-dev container and update to React 18 #46

Closed Henriquelay closed 2 years ago

Henriquelay commented 2 years ago

Resolves #8.

Big size update. :truck:

This creates a web-development container, with update React 18 and all dependencies, updated and balated .eslintrc.yaml. Lots of things had to change to update to React 18. Mostly, function components now don't return React.FC, and instead it all uses a generic JSX.Element. Also, no need to import from React everytime :tada:.

I had to do both actions at the same time because of some errors I was getting with installing React on the container, and updating solved it (and caused a bunch of new others, obviously).

Also added configs for Thunder (HTTP) Client.

I have continued on the same branch as before because the issue has been reopened, but thinking about it now, maybe it wasn't a good idea. But it's too late.

Henriquelay commented 2 years ago

Shit, I marked to merge to master.

Henriquelay commented 2 years ago

There is no conflict, GitHub is drunk. image

image

AtilioA commented 2 years ago

I don't know if this private stuff is working (couldn't reproduce) but LGTM :+1:

Henriquelay commented 2 years ago

I'll resolve the merge conflicts later today then we can finally merge it!

Henriquelay commented 2 years ago

I have merged manually through the GitHub web editor and have not tested yet, so there is exactly zero chance this goes wrong.

AtilioA commented 2 years ago

Seems good to me now, but we're missing Toast messages and feedback is totally bonkers right now

Henriquelay commented 2 years ago

we're missing Toast messages

Toast messages were never there, were they?

AtilioA commented 2 years ago

bruh i can't scroll

Henriquelay commented 2 years ago

I can't take it anymore ðŸ¤