AtingTot / wave-protocol

Automatically exported from code.google.com/p/wave-protocol
0 stars 0 forks source link

Implement WAVELET_SET_TITLE operation #215

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I tried to run some of my robots I made for GWave on Wiab. I discovered several 
issues and inconsistencies - with the most annoying one being lack of support 
for the WAVELET_SET_TITLE operation. 
In GWave after setting a title - one can assume the root blip has content that 
starts with this title - which doesn't hold in Wiab. 
If the robot tries to apply some annotation to the title - like making it 
bigger (DigestBotty and WavyEmail bots do this a lot) - they get out of the 
range which results in error. 
Also, the title just gets lost - while it is the most important piece of info 
in the blip.

The issues can be mitigated by simple implementation of wavelet.setTitle 
operation - by inserting the title text in the beginning of the root blip and 
making it bold.

If this suggestion sounds good - I have no problem to submit a patch.

Original issue reported on code.google.com by vega113 on 7 Feb 2011 at 6:32

GoogleCodeExporter commented 9 years ago
The title model is more complex than just inserting text at the beginning and 
making it bold. See TitleHelper. Unfortunately the robot API implements a model 
that doesn't match the native wave model and requires rather complex code to 
adapt between the two. In the model it's possible for a wave to have a title 
that does not appear in the content, but the robot API munges that up.

Original comment by ano...@google.com on 11 Feb 2011 at 12:05

GoogleCodeExporter commented 9 years ago
Closed by revision 9fcd00ddcb13

Original comment by vega113 on 19 Apr 2011 at 10:17