memory leak in Game::Do1Assassinate

Atlantis-PBEM / Atlantis

Main Atlantis development Repository

GNU General Public License v2.0

53 stars 37 forks source link

memory leak in Game::Do1Assassinate #22

Closed ennorehling closed 4 months ago

ennorehling commented 8 years ago

The variable seers is allocated in this call to CanSeeSteal (new AList) in line 322:

AList *seers = CanSeeSteal(r, u);

This list is never deleted anywhere later in the function, which has multiple return paths (I believe this is the kind of thing std::auto_ptr<> is good for).

jt-traub commented 4 months ago

This, being a memory leak, is going to be fixed. Fixing in upcoming PR #193