Atlantiss / NetherwingBugtracker

Official bugtracker for the Netherwing and Karazhan (2.4.3) realms.
52 stars 36 forks source link

[core][mechanic][spell] Spells without globcal cooldown inducing a global cooldown when spammed #5578

Closed gabbat closed 1 year ago

gabbat commented 5 years ago

Description: skills without global cd provoke a global cd every now and then. no idea what the cause is, but it happens daily. not very often, but reproducable, with or without addons activated. happens on both icy veins and counterspell.

Current behaviour: e.g. spamming frostbolt, castin icy veins, global cooldown, next frostbolt

Expected behaviour: you should be able to chaincast frostbolt, icy veins, frostbolt.

Server Revision: 2930

Wolffenstein commented 5 years ago

That's not enough info to fix it I'm afraid.

Tenoutoften commented 5 years ago

https://github.com/Atlantiss/NetherwingBugtracker/issues/251


Description: Spam casting Conjure Water starts the global cooldown everytime you hit the key

Current behaviour: If you spam Conjure Water and press again conjure water like .5 seconds before the first cast goes off, it starts another global cooldown for no reason and you can't chain cast it.

Expected behaviour: Spamming a spell while another spell is being casted shouldn't start a GCD

Server Revision: 2032

Not sure why this is need research

https://gfycat.com/PerfumedBewitchedHapuka

If you spam cast any spell (frostbolt here) you will get another action is in progress and GCD doesn't go off If you spam conjure, there are no errors and the global cooldown starts again even if you're still casting

gabbat commented 5 years ago

That's not enough info to fix it I'm afraid.

ofc it is not, but as it is easily reproducable a fix is needed. I can not tell you what the cause is, I did not code the spell queueing system. it simply is a major bug which you can easily reproduce, so it can happen to everyone and therefor has a high priority.

Easyfraggy commented 5 years ago

Might be the same thing sometimes preventing 3:2 steady macro from working properly.

GCD is client side though - so I'm not sure what wolf can do about it 🤔

gabbat commented 5 years ago

please fix this. it is easily reproduceable and pretty devestating for any pve/pvp mage. makes playing the class feel so bad when it happens

gabbat commented 5 years ago

easily reproducable, spam any dmg spell with a casting time, spam icy veins and dmg spell, get global cooldown. pls fix

gabbat commented 5 years ago

this is reproducable on paladins as well with divine favor, so it affects all classes that use spells not on the global cooldown. Please try to fix this, do you need any more information?

tsu-1 commented 5 years ago

@Wolffenstein

taurenrogue commented 5 years ago

yet another tank has died today because divine favor caused a GCD

gabbat commented 5 years ago

push, still a major issue @Wolffenstein

Wolffenstein commented 5 years ago

Fixed in rev 2995.

Mikik3jr commented 5 years ago

I want to reopen the case, because as a holy paladin if I cast a holy light, then I queue up a Divine Favor + Holy light (in this order) then I get the global CD (GCD after Divine Favor).

(Same can happen with Divine Illumination)

Mikik3jr commented 5 years ago

rev 2996 @Wolffenstein

gabbat commented 5 years ago

not fixed in 2995, requesting reopen

JeppeHJ commented 5 years ago

Bump. Critical bug that needs fixing.

A core bug that affects most classes:

For mages, it is still bugged with Conjure Water like Tenoutoften described, also Icy Veins spamming during a cast causes this. For Paladins, Illumination is causing GCD if spammed before a cast is over (same behavior). For Hunters, spamming Arcane Shot or Steady Shot before the cast is over sometimes causes an extra GCD, illustrated here: https://clips.twitch.tv/BitterReliablePhonePupper where I lose a GCD because I am spamming Arcane Shot during a Steady cast. I have countless examples and clips of this behavior.

This is a core mechanic bugged affecting everyone, should be highest priority. It most certainly is not fixed.

Easyfraggy commented 5 years ago

The fix was reverted because it caused an exploit.

Godmatik commented 5 years ago

Still occurs

gunzbngbng commented 4 years ago

The issue still exists for hunters. And it's incredibly destructive. Often it causes spells like scatter shot to throw up an error "Target facing..." while you're face to face. It eats your global. And scatter shot does not get used.

Aimed shot CONSTANTLY triggers a GCD after use.

The delay makes it often impossible to interrupt even longer casts with silencing shot. This is, obviously, a huge issue in PvP.

Thank you.

tsu-1 commented 4 years ago

@Wolffenstein

Mikik3jr commented 4 years ago

During sealtwisting when I switch to blood, I judge it and I try to use Seal of Command again, but it doesn't happen. It says the spell is not ready yet. I don't get the smooth chaincast the flash of light.

It is like you use a spell which has a cast time, then like at 1.4s of the GCD you chain up a no GCD spell such as Divine Illumination, Divine Favor, Judgement etc. AND you try to chain (again around at 1.4s GCD after the first casted spell) it does not chain properly and it puts everything on GCD again.

Wolffenstein commented 1 year ago

Fixed in rev 3869.