Judgement of Wisdom Not Proccing From Attacks at Correct Rate

spacct commented 7 months ago

Description: Judgement of Wisdom is proc'ing much less frequently than expected from physical attacks.

Current behaviour: Out of 375 attack hits, Judgement of wisdom restored 8,880 mana (or 120 procs), giving it a rate of 32%. Below are pictures from the combat log. These vast swaths without a JoW proc are commonplace.

Note: this test was done while not at 100% mana to ensure that having full mana was not the cause of the bug.

I believe this bug may be indicative of a problem with many chance on hit procs (trinkets like dst, other trinkets and class talents, etc). For whatever reason, many hits are not registering with the proc chances.

Pictures from Details showing the 375 attack hits (217 steady hits and 158 auto shot hits), as well as the 8,880 mana restored from these cumulative attacks.

Expected behaviour: Judgement of Wisdom should be proc'ing from melee and ranged attacks at a 50% rate. The 8,880 mana restored in this case should have been 13,838. This is a near 5,000 mana difference, and 5,000 mana is a huge difference on a raid boss encounter.

https://www.wowhead.com/tbc/spell=20354/judgement-of-wisdom

Server Revision:

spacct commented 6 months ago

Upon further investigation, this bug is confirmed through raid boss combat logs. Further analysis on a larger sample was done on boss logs to confirm.

Faceless logs from Brutallus kill on Apr 28 show that after Judgement of Wisdom was applied, it stayed on the boss throughout the remainder of the fight (final 3:51 of the 4:48 fight). For those classes using mana bars (excluding pets, warriors, rogue, feral druid), 3,405 attacks were made on the boss after Judgement of Wisdom was applied (see table below), and 1,036 of those attacks resulted in a Judgement of Wisdom proc. This is a rate of 0.3043 (30.43%), and this corroborates the post above (which showed a 32% proc rate during the test of 375 attack hits).

Note: the attack analysis below excludes Seal of Blood and Seal of Command which both appear to proc Judgement of Wisdom (for the purpose of care not to include anything improperly). This makes the above 30.43% rate conservatively high (it is likely even lower).

Wolffenstein commented 6 months ago

Fixed in rev 3991.

spacct commented 6 months ago

Tested on PTR follow server update. Judgement of Wisdom still proc'ing at lower than expected rate. Appears to be unaffected by change to steady shot.

171 hits, 4,292 mana restored (58 procs); 33.92% proc chance.

Tested Go For the Throat hunter talent proc and Bow of the Betrayer mana drain, and after short tests, both appear to be working properly following server update.

For additional context, I used the Faceless logs mentioned in my previous comment to compare procs for Enhancement Shaman melee attacks and damaging spells, and the proc rate for the Shaman for Judgement of Wisdom was:

103 Judgement of Wisdom procs, 383 attacks hit for a 26.89% proc chance.

I believe the Judgement of Wisdom proc chance is separately bugged from the Steady Shot issue affecting Go for the Throat and Black Bow mana drain.

Combat log for reference on most recent Judgement of Wisdom test on PTR following server update (50% proc chance intended; existing proc rate is ~30%):

Atlantiss / NetherwingBugtracker

Judgement of Wisdom Not Proccing From Attacks at Correct Rate #9070