Righteous Weapon Coating Proc Chance Too Low

[spacct]

Description: Righteous weapon coating's proc chance is too low or behaving incorrectly.

Current behaviour: Righteous weapon coating can take up to 2 minutes to proc (following internal cooldown being cleared).

This test was done with 2x 1-handed daggers (both with Righteous Weapon Coating applied to minimize proc downtime) over a 10 minute window in Sunwell Plateau. A 3 minute proc occurrence (1 minutes ICD + 2 minutes to proc) was experienced on 1st 10 minute test (meaning this type of delay is not uncommon).

Screengrab of a 1 min and 28 second gap and a 2 mins and 8 seconds gap without a proc (2nd 10-minute test). With 2x 1-handed daggers (1.48 attack speed with static haste; average of 1 attack every 0.74 seconds) means the proc chance will suddenly nearly disappear for long swaths of time. In the case of the 2 minute and 8 second gap (128 seconds), if the internal cooldown is 35 seconds, this means the internal cooldown was cleared for 93 seconds. In 93 seconds, 125 attacks were made (93s / 0.74s per attack = 125.67 attacks) before the next proc. Even if the proc chance was only 5%, a gap like this would only occur at a rate of 0.0016 (0.16% of the time), and should never be seen in both sets of 10 minute tests:

Expected behaviour: Proc occurrence should be almost as soon as ICD ends rather than as experienced (1 min ICD + 2 min to proc) in a 10 minute test. This can be seen in comments from 2008:

https://www.wowhead.com/tbc/item=34539/righteous-weapon-coating#comments

Server Revision:

[Godmatik]

Needs retest with new spell proc branch