search

Atlas-Assistance-Dogs / atlas-dogs

Repository for Atlas Dogs flows in Salesforce
1 stars 1 forks source link

454 filter team #457

Closed deb761 closed 1 year ago

deb761 commented 1 year ago

Critical Changes

Changes

Issues Closed

454

atlasjen commented 1 year ago

Testing this most recent version

Other seemingly related file upload things

deb761 commented 1 year ago

I renamed Client to "Team Client". N/A only has "Contact Form" in it. I haven't touched the Lead record page at ALL for this PR. Not sure why Files isn't in there. I'll check it out, maybe there is an LWC error. Ah, there are no Category Rules for Lead. Should there be? As for the Background Check record page, it has the custom Related files list, or are you talking something else?

atlasjen commented 1 year ago

Oh right, i was thinking Client would still have the ADSiM files, but they have their own category but display under client details. I would say it might make more sense to rename Assistance Dogs Set in Motion as a category to "Client" and then have file types of ADSiM Pre-Application, ADSiM Application, ADSiM Program Agreement. The other reason for this is if there are other random general files we want to upload under client, but that don't have last* dates that gives us a way to do that.

IGNORE- THIS IS FINE: For background check, it should just have the normal file component. That is what it has in prod right now.

We could overload the File Upload for Lead. Right now it is the normal file upload component and we classify the files when we convert to contact. Typically they will be volunteer resumes or interview notes, but as a lead can go any which way and won't have many files, i figured we just leave it the generic and they become files on contact when converted. I think we leave this alone.

Then the only other issue in my list above is that Team Client and Team Dog records would still be copied to display in the Contact and Dog locations like they did previously.

atlasjen commented 1 year ago

Agreed- leave Assistance Dogs Set in Motion as a category. Leave Client out. If start wanting arbitrary client files, can manually add to Content Version and Category Rules w/o requiring code changes as long as don't need "last * dates"

deb761 commented 1 year ago

I changed the label for Client category to Team client. Since I thought you said you only wanted the client options available for teams. Since these Sent from my iPhoneOn Apr 15, 2023, at 4:25 PM, atlasjen @.***> wrote: Testing this most recent version

Team Dog and Team Client files are not visible in Client and Dog. I see your comment above about removing that link... but we def still want to be able to view them under Contact and Dog. Type would just be "team client" or "team dog". from the rest of my testing file uploads and dates in contact and dog all seem to work as expected using arbitrary new Document Types seems to work. I couldn't try it in client due to the next item "Client" is now missing as a Category in the Document Type mapping under Content Version

Other seemingly related file upload things

File upload dialog under Background Check shouldn't be this custom dialog; it should be normal system one [CEUs seem to use the proper one, so not sure why background check is different] file upload still missing from Lead (i assume a page layout thing)

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were assigned.Message ID: @.***>

atlasjen commented 1 year ago

relates to #478