Atlas-Assistance-Dogs / atlas-dogs

Repository for Atlas Dogs flows in Salesforce
1 stars 1 forks source link

Last Facilitator Certification Date doesn't update if it is to an earlier date (or deleted) #508

Closed atlasjen closed 6 months ago

atlasjen commented 6 months ago

I believe the issue is

1) if a file is removed the Last Date isn't cleared or rolled back to the previous last date 2) if a file's date is updated that was older than the previous last date, the last* date isn't updated.

Here is the use case. This is on Madeline Jill Mohr's record in prod. (release 1.5)

Laura accidentally uploaded a Trainer Certification document and used the Team Facilitator type. It had a date of 12/12/23.

There previously had been a Facilitator Certification document w/ the Team Facilitator type.. It had a date of 7/25/23. image

As a result the Last Facilitator Certification Agreement date was stomped on and changed to 12/12/23. That is expected proper behavior.

To attempt to fix this, I had her: 1) change the type on the most recent team facilitator one to trainer and save. That fixed the last trainer certification date. 2) try to change the date on the other team facilitator one by a day or so and save to see if it would trigger an update to the Last Facilitator Date. It changes the document date that is shown in the related file list, but the Last Facilitator Certification Agreeement date isn't changing.

image

image

She also tried deleting the Team Facilitator Agreement. That means, the date should have rolled back to the most recent one there image

However, when i go look at position details (after refresh), this is what i see (it didn't clear the date or reset it) image

I then upload the doc again but nothing changes in related.

deb761 commented 6 months ago

I'm concerned that any fix would wind up pushing the trigger over the SQL query limit. I'll try it out, but why didn't you tell her to just set the correct date in the Last Facilitator Certification Agreement field?

atlasjen commented 6 months ago

I will have her do that but for now left it so you could see the issue.

From: Deborah Engelmeyer @.> Sent: Saturday, December 23, 2023 7:26 AM To: Atlas-Assistance-Dogs/atlas-dogs @.> Cc: Jennifer Kolar @.>; Author @.> Subject: Re: [Atlas-Assistance-Dogs/atlas-dogs] Last Facilitator Certification Date doesn't update if it is to an earlier date (or deleted) (Issue #508)

I'm concerned that any fix would wind up pushing the trigger over the SQL query limit. I'll try it out, but why didn't you tell her to just set the correct date in the Last Facilitator Certification Agreement field?

— Reply to this email directly, view it on GitHubhttps://github.com/Atlas-Assistance-Dogs/atlas-dogs/issues/508#issuecomment-1868315314, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APYTKLOUZ2BXI2XXNLVDOBLYK3ZZPAVCNFSM6AAAAABA67XMZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGMYTKMZRGQ. You are receiving this because you authored the thread.Message ID: @.**@.>>

atlasjen commented 6 months ago

what did we decide to do with this?

deb761 commented 6 months ago

Update the date manually in these situations, as the trigger solution is too query intensive.

atlasjen commented 6 months ago

ok. closing.