search

Atlas-Assistance-Dogs / atlas-dogs

Repository for Atlas Dogs flows in Salesforce
1 stars 1 forks source link

Feature/file upload no category #543

Closed deb761 closed 1 month ago

deb761 commented 1 month ago

Changes

Changed file controller to allow everyone access to files with no category.

Issues Closed

537

atlasjen commented 1 month ago

this seems to work just fine now. Curious what the difference of NA vs blank is.. with N/A we have a contact form as an option which applies to everyone. do we want to default to N/A for everything? Approving this PR as it does resolve the issue listed, but not merging it until you comment on what we want to do here.

deb761 commented 1 month ago

The difference between N/A and blank, null, empty-string, is just that: it didn't match the search criteria.

Conceptually it can mean they are equivalent, or not, depending on business rules. Since these are optional fields, we need to rely on Molly and Laura to make sure they set the category properly to prevent others from seeing files.

If we want to be more stringent, we can consider these required fields, or at least Category is, and fall back to "N/A" for those ContentVersions that don't have it set.

atlasjen commented 1 month ago

okey dokey. merging it in .